Open
Conversation
Member
|
I'm totally down for shipping our own back button still. I think if we go this route we have to make it a widget in the library though because there's quite a few cases where we're using a custom sidebar so it's really inconvenient to have to create this back button over and over |
Member
Author
|
Maybe even in Granite? I could see it being used in app center and videos as well |
Member
|
@leolost2605 Yeah I think the only issue there is that it would introduce a dependency on Adw in Granite. Which is probably fine at this point 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something like this (Ignore that the back button is still broken for me):